fix(confirmations): hide irrelevant alerts on money account transactions - #45572
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (4 files, +114 -31)
|
602c006 to
3ae3ee1
Compare
bad6d95 to
57aa70f
Compare
3ae3ee1 to
9f9d7ec
Compare
57aa70f to
b5e5b0a
Compare
Builds ready [b5e5b0a]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 11 warn · 🔴 4 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [94c268a] [reused from 4965778]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 10 warn · 🔴 2 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
2c082b6 to
ebf0944
Compare
94c268a to
e4a62bc
Compare
Builds ready [e4a62bc]
⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 9 warn · 🔴 2 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ebf0944 to
a0cca52
Compare
e4a62bc to
2f0728a
Compare
Builds ready [2f0728a]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 8 warn · 🔴 4 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [2f0728a]
⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 8 warn · 🔴 3 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
a0cca52 to
395e8fd
Compare
2f0728a to
c35058f
Compare
Builds ready [c35058f]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 9 warn · 🔴 3 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
395e8fd to
57344f3
Compare
c35058f to
6a15a3d
Compare
Builds ready [6a15a3d]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 5 warn · 🔴 3 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
6a15a3d to
931323c
Compare
57344f3 to
351ecf7
Compare
Builds ready [931323c]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 10 warn · 🔴 4 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [931323c]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 10 warn · 🔴 4 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
351ecf7 to
3a4e727
Compare
931323c to
5ddd214
Compare
|
Builds ready [5ddd214]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 11 warn · 🔴 3 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|



Description
Money account deposits and withdrawals were showing two confirmation alerts that are not relevant to them:
useSelectedAccountAlerts): money account flows are wallet-initiated and always sent from the dedicated money account, which is never the selected account group — so this warning fired on every money account transaction as noise.useMultipleApprovalsAlerts): MetaMask Pay flows (money account deposits/withdrawals, perps, mUSD) batch their own approvals internally. This mirrors mobile'sMM_PAY_TRANSACTION_TYPESskip inuseBatchedUnusedApprovalsAlert.Changes
useSelectedAccountAlerts: skip the alert when the confirmation is a money account transaction (viagetMoneyAccountTransactionType).useMultipleApprovalsAlerts: skip the alert when the confirmation contains aPAY_TRANSACTION_TYPEStransaction, matching mobile parity.Related issues
Fixes: CONF-1822
Manual testing steps
🤖 Generated with Claude Code